The InformationPage's continueButton is special cased to behave differently between mobile and desktop, as defined in the design file. https://github.com/bitcoin-core/gui-qml/pull/171 introduced this functionality. And https://github.com/bitcoin-core/gui-qml/pull/194 made it work with the new InformationPage control and it's scrollView. The logic on the scrollViews contentHeight implemented in 194 was faulty, and leads to a binding loop. This was hidden by the fact that we can't see terminal output when running the android app.
Expected behaviour
No binding loop.
Steps to reproduce
Apply this patch, then run the gui so this logic is ran when on desktop:
Current behaviour
The InformationPage's continueButton is special cased to behave differently between mobile and desktop, as defined in the design file. https://github.com/bitcoin-core/gui-qml/pull/171 introduced this functionality. And https://github.com/bitcoin-core/gui-qml/pull/194 made it work with the new InformationPage control and it's scrollView. The logic on the scrollViews contentHeight implemented in 194 was faulty, and leads to a binding loop. This was hidden by the fact that we can't see terminal output when running the android app.
Expected behaviour
No binding loop.
Steps to reproduce
Apply this patch, then run the gui so this logic is ran when on desktop:
Relevant log output
How did you obtain Bitcoin Core
Compiled from source
What version of Bitcoin Core are you using?
master
Operating system and version
Ubuntu 22.04.2 LTS x86_64
Machine specifications
No response