search

bitcoin-core / gui-qml

Bitcoin GUI (experimental QML-based fork)
MIT License
107 stars 40 forks source link

Ask before opening external links #343

Closed jarolrod closed 6 months ago

jarolrod commented 1 year ago

Introduces an external link confirm popup window that prompts the user to acknowledge that they really want to visit the external link. This is based off the design file

This contains a menu bar with a title, but is missing the close button. It is also missing the "Don't ask again" button. These require some more conversation and can be addressed in a follow-up.

This deviates from the design file in providing a mobile layout that positions the buttons in a column layout instead of a rowlayout. cc @GBKS @mouxdesign

Desktop Layout Mobile Layout
Screen Shot 2023-06-03 at 2 11 30 AM Screen Shot 2023-06-03 at 2 12 43 AM

Windows Intel macOS Apple Silicon macOS ARM64 Android ARM32 Android

jarolrod commented 1 year ago

Updated from 3a3f8c2 to e9b6d4a

Added a navigation bar with a Title, but without a close button within the navigation bar.

thebagmaster commented 1 year ago

ACK e9b6d4a Verified on Ryzen 9 Ubuntu 22.04.2 and Note 9 Android 10 on fully synced nodes.

GBKS commented 1 year ago

Good idea with the column layout for mobile. Small thing, the overlay should have a 1px border around it (neutral 6 color).

GBKS commented 1 year ago

@jarolrod pointed out that this should probably be an application-wide setting. So the first time a user opens an external link, we ask them. If they check the "Don't ask again" option, we don't ask anymore. But they can change this behavior again in the settings. Here's a mock-up for that.

image

promag commented 11 months ago

Concept ACK, approach NACK.

hebasto commented 11 months ago

Please rebase.

https://discord.com/channels/903125802726596648/903126039084015638/1146922061449666602

jarolrod commented 11 months ago

rebased over main

GBKS commented 6 months ago

This issue has been around for a long time. What is needed to wrap it up?