bitcoin-core / gui-qml

Bitcoin GUI (experimental QML-based fork)
MIT License
107 stars 40 forks source link

Center info page #345

Closed thebagmaster closed 11 months ago

thebagmaster commented 1 year ago

The design file was updated to show the cover for the onboarding prompt was changed to be centered. This required some cleanup in both in InformationPage as well as OnboardingCover. This small change should help with future usages of InformationPage.

The changes include:

edit: see comments below for working screenshots.

ss

Windows Intel macOS Apple Silicon macOS ARM64 Android ARM32 Android

thebagmaster commented 1 year ago

Rebased 27381c0 Added the states back in Had to respect button position for desktop should behave like design doc again Also used isMobile instead of an inline test SS1 SS2

jarolrod commented 11 months ago

Closing for now; this needs to be rebased over main, but we'll be taking a different approach as to the view components and how we handle desktop vs mobile