search

bitcoin-core / gui-qml

Bitcoin GUI (experimental QML-based fork)
MIT License
107 stars 40 forks source link

Standardize post-onboarding settings window titles to navbar #346

Closed jarolrod closed 1 year ago

jarolrod commented 1 year ago

This moves all settings pages titles post-onboarding into the navbar, standardizing where the title is for all pages. Whereas, currently, we have some within the page content and some in the page navbar. See this issue: https://github.com/BitcoinDesign/Bitcoin-Core-App/issues/55

Windows Intel macOS Apple Silicon macOS ARM64 Android ARM32 Android

jarolrod commented 1 year ago

cc @GBKS @mouxdesign

jarolrod commented 1 year ago

@GBKS @mouxdesign The screenshots below show what the PR does comparing master and PR. Note that this pr only affects the page titles post-onboarding. When you are on the node page.

Master

settings about developer display storage connection proxy peers network
1-settings-master 2-about-master 3-developer-master 4-display-master 5-storage-master 6-connection-master 7-proxy-master 8-peers-pr 9-network-master

PR

settings about developer display storage connection proxy peers network
1-settings-pr 2-about-pr 3-developer-pr 4-display-pr 5-storage-pr 6-connection-pr 7-proxy-pr 8-peers-pr 9-network-pr

What it doesn't do is change where the page title is during onboarding. But, maybe we want to standardize the page titles into the navbar everywhere?

PR during onboarding

about developer storage connection proxy
onboarding-about onboarding-developer onboarding-storage onboarding-connection onboarding-proxy
GBKS commented 1 year ago

Thanks for doing this. For reference, the reason why titles are bigger during onboarding is consistency. During onboarding, everything is bigger and chunkier. It should feel (and be) really simple, compared to later points in the experience when you navigate the settings pages with a more functional mindset. See the images below for the types of screens we have during onboarding.

image

GBKS commented 1 year ago

ACK https://github.com/bitcoin-core/gui-qml/pull/346/commits/8f81f0d44fd80bb1027235f3bb0bde950a0615b8