search

bitcoin-core / gui-qml

Bitcoin GUI (experimental QML-based fork)
MIT License
107 stars 40 forks source link

Revert "qml: remove broken implicitHeight on InformationPage" #347

Closed johnny9 closed 1 year ago

johnny9 commented 1 year ago

This reverts commit 726a734cd6e5eb6ccd6647d4214ad379a79571e2.

It turns out implicitHeight ends up fixing the binding loop on mobile with the binding to the contentHeight of the scrollview. I also tested this against the new Display settings changes and the original issue is no longer there with parent being null.

Windows Intel macOS Apple Silicon macOS ARM64 Android ARM32 Android

johnny9 commented 1 year ago

Original PR is https://github.com/bitcoin-core/gui-qml/pull/313

hebasto commented 1 year ago

the original issue is no longer there with parent being null.

Cannot confirm it:

2023-06-05T11:04:13Z GUI: qrc:/qml/controls/InformationPage.qml:12: TypeError: Cannot read property 'height' of null

Steps to reproduce:

  1. Settings --> Network Traffic
  2. Back