search

bitcoin-core / gui-qml

Bitcoin GUI (experimental QML-based fork)
MIT License
111 stars 40 forks source link

NavigationBar2 control #358

Closed promag closed 10 months ago

promag commented 1 year ago

This is an alternative to the existing NavigationBar component. The layout is such that the center section is horizontally centered when possible, and the right section is right aligned. Also, Loaders are avoided with this new approach.

Since the approach is quite different from the other navigation bar, a full refactor would be substantial, harder to test and subject to breaking changes. For that reason, both implementations will be available for a short period of time. More pull requests will follow to replace the old implementation once this is accepted.

Finally, the new navigation bar is used on the Peers, NodeRunner, and ThemeSettings pages.

jarolrod commented 1 year ago

a full refactor would be substantial, harder to test and subject to breaking changes. For that reason, both implementations will be available for a short period of time. More pull requests will follow to replace the old implementation once this is accepted.

In that case, number the PR's and add a title for the series: (1/n) Reimplement NavigationBar Control