DRAFT: WSL-Ubuntu-Android Build Guide

[D33r-Gee]

This is an updated version of PR #351 It has been rebased and the WSL Ubuntu Android install guide has been added to build-android.md Let me know if there are any issues

[D33r-Gee]

Rebased main, deleted WSL_APK_INSTALL.md and modified build-android.md so the wsl guide can be found there. Let me know if there's anything that needs to be updated @jarolrod

[hebasto]

Please add PR description, update PR title, fix linter issues and clean commit history.

[D33r-Gee]

Please add PR description, update PR title, fix linter issues and clean commit history.

Took care of the above. Re: clean commit history, please let me know if that's the way to do it or if you'd prefer a different approach?

[D33r-Gee]

Thanks @pablomartin4btc for Concept Ack this PR

I will squash the commits and rebase early next week as I'm traveling for the holiday.

On Wed, Nov 22, 2023, 20:33 pablomartin4btc @.***> wrote:

@.**** commented on this pull request.

Concept ACK

I'll try to validate the instructions following them and checking the built is correct. Is this exclusive to WSL or can be done on Ubuntu 22.04.

Re: clean commit history, please let me know if that's the way to do it or if you'd prefer a different approach?

I think there's no need to have so many commits, you could squash them all into only one.

Also, perhaps you need to rebase?

— Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/gui-qml/pull/366#pullrequestreview-1745260072, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2P6LNZVG3DCPSXE4EDXAPLYFZHQJAVCNFSM6AAAAAA4VFKKCSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONBVGI3DAMBXGI . You are receiving this because you authored the thread.Message ID: @.***>

[D33r-Gee]

Is this exclusive to WSL or can be done on Ubuntu 22.04.

It should work with Ubuntu 22.04 proper.

Squashed the commits and rebased with main

Thanks again for reviewing @pablomartin4btc

[D33r-Gee]

thanks @pablomartin4btc, for taking a look... squashed it down to 1 commit.

I'll try to follow the guide at some point next week and give a deeper review.

Sounds great!

Thanks for working on this!

with pleasure

[hebasto]

@D33r-Gee

The diff looks too big (956 files) for a build guide, doesn't it?

[D33r-Gee]

The diff looks too big (956 files) for a build guide, doesn't it?

@hebasto, yes thanks for pointing it out. I didn't do proper house cleaning when synching my fork. It should be resolved now.

[D33r-Gee]

Hi @pablomartin4btc ,

Thanks so much for going through the whole guide and testing it on different devices,,, amazing!

I've finished the entire guide, sorry it took me a while cos I've checked different devices and had to learn to use the tools.

No worries, happy you got through and thanks for suggesting improvements!

I will look them over, test them then update the commit in the coming days...

[D33r-Gee]

@pablomartin4btc , thanks for your reviews and suggestions I've implemented them here https://github.com/bitcoin-core/gui-qml/pull/366/commits/8e20109af7cdd712bd951a58ced22716497b1cac Let me know your thoughts and/or if there's anything I missed?

[D33r-Gee]

new commit 7687e2cb347772a96f20039abe65f5d241e2e57f

Added your suggestions @pablomartin4btc

[pablomartin4btc]

I think we can use this guide for both, perhaps you need to identify and separate the steps specifically for WSL (including usage of usbip, which is not required for non-WSL) and that's all I can say, it worked fine for me.

Sorry, what I mentioned above perhaps can be done on a follow-up, apologies if you started doing that already :pray:.

[D33r-Gee]

Sorry, what I mentioned above perhaps can be done on a follow-up, apologies if you started doing that already 🙏.

No worries... Apologies for the late response was focused on the AssumeUTXO integration

I think we can use this guide for both...

That's a great idea, once I implement your latest suggestions perhaps it can be merged and we can open a new PR detailing both OSes or we can keep collaborating on this one till we feel it's ready to be merged...

@pablomartin4btc thoughts?

[D33r-Gee]

updated and rebased https://github.com/bitcoin-core/gui-qml/pull/366/commits/5b7da4aed5da0fe3a9b1ab2c5c87c74527c028a6

Thanks @pablomartin4btc for testing and the suggestions

[hebasto]

Building for Android is currently broken in the Bitcoin Core master branch. This is the main reason why there have not been syncing to the master branch recently.

I suggest to draft / postpone this PR until CMake + Qt6 are landed to the master branch.

[D33r-Gee]

I suggest to draft / postpone this PR until CMake + Qt6 are landed to the master branch.

Ah great to know... yes setting this PR to draft then