Introduce Wallet main pages - Githubissues

bitcoin-core / gui-qml

Bitcoin GUI (experimental QML-based fork)

MIT License

106 stars 40 forks source link

Introduce Wallet main pages #389

Closed johnny9 closed 3 months ago

johnny9 commented 4 months ago

Adds DesktopWallets.qml and MobileWallets.qml. These pages are the central navigation points for the application when wallets are enabled.

A core piece of the page is controlling the navigation flow between the sub pages of the wallet application. For the desktop implementation, a new NavigationBar design is used along with a Stack layout to hold the pages. For mobile, a DirectionalStackView is used to push and pop the wallet sub pages based on the UX designed flow.

[]()

GBKS commented 3 months ago

Just tested because of the mention and looks like a great start. Lots of details to tweak, of course, as pablo pointed out, but it's also a draft PR. Is there anything specific to give feedback on at the moment?

johnny9 commented 3 months ago

Update from 4b43dfa to 25bbfeb

Rebased with main
Removed mobile desktop pages
Created commits for each new Icon
Created commits for each separate functional piece.

johnny9 commented 3 months ago

from 25bbfeb to b5a1356:

Removed mini blockclock implementation. Will add it later as a separate PR.

johnny9 commented 3 months ago

Update from b5a1356 to 37e3af6

Fix for gear icon transitioning to blank as pointed out by @MarnixCroes
Set anchors.centerIn=parent for the BlockClock

johnny9 commented 3 months ago

* there is a bug where sometimes the gear-outline icon is highlighted, while not selected. this can happen after having minimized the window. (happened twice, not sure exactly how to repro)

I haven't had this happen yet but i wonder if it was fixed when i fixed the color change animation for it where it was going blank in transition

johnny9 commented 3 months ago

⭕ commit [6e42abc](https://github.com/bitcoin-core/gui-qml/commit/6e42abc89304ee0ebe22a16d561cd8813b687548) (`qml: Add property to hide NetworkIndicator on BlockClock page`), what this should do? I think I'm missing something because on Desktop mode, I made it visible (`showNetworkIndicator: true`) on `mainnet` but I don't see the difference. Could you please shed some light on this?

This will show the network indicator if its not on mainnet (testnet/signet) on the block clock control. The reason i added the bool is because it is redundant in desktop wallet mode because the indicator is already at the top in the navigation bar.