bitcoin-core / gui-qml

Bitcoin GUI (experimental QML-based fork)
MIT License
106 stars 40 forks source link

UI Only Custom Datadir #392

Closed D33r-Gee closed 3 months ago

D33r-Gee commented 3 months ago

This pull request is a focused iteration of #390, intended to isolate and test the UI frontend elements. Backend functionality has been intentionally excluded to streamline the testing, review, and merge process.

Ubuntu Screenshots ![Screenshot 2024-03-14 124000](https://github.com/bitcoin-core/gui-qml/assets/111142327/a8d8ebbc-c66c-4626-ba7a-630f19c889ae) ![Screenshot 2024-01-29 074759](https://github.com/bitcoin-core/gui-qml/assets/111142327/fea1b72d-2760-436c-aba5-2094b5826fa4) ![Screenshot 2024-01-29 074734](https://github.com/bitcoin-core/gui-qml/assets/111142327/768f93a0-4f9c-46cc-9b31-7d9fcabaaf1e)

Prerequisites

For testing this pull request, ensure you have the following Qt modules installed:

sudo apt-get install qtdeclarative5-dev
sudo apt-get install qtquickcontrols2-5-dev
sudo apt-get install qml-module-qtquick-controls2
sudo apt install qml-module-qtquick-dialogs

Implementation Details

This introduces FileDialog class for a user-friendly selection experience.

Follow up PR will add display of the custom datadir in StorageSettings.qml

D33r-Gee commented 3 months ago

Update the README at https://github.com/bitcoin-core/gui-qml/tree/main/src/qml with the additional packages that need to be installed.

Good call @johnny9! Just pushed a new commit with the updated doc.

Now it's pretty much equivalent (give and take) with @jarolrod's #273

D33r-Gee commented 3 months ago

double-clicking on Custom opens the storage selection in the background. single-click works ok

Thanks @MarnixCroes, good catch... wasn't able to reproduce on WSL Ubuntu 22.04... Found a potential workaround by adding a timer, will implemented in a future PR since it's little out of scope for this one.

649c2a5 you added qml-module-qtquick-dialogs, the other 3 qtdeclarative5-dev qtquickcontrols2-5-dev qml-module-qtquick-controls2 should be added to the instructions as well?

those are actually found here in the qml/README.md: https://github.com/bitcoin-core/gui-qml/blob/649c2a5af80092e4f43497309aafe5785a2b2bdd/src/qml/README.md?plain=1#L66 and here: https://github.com/bitcoin-core/gui-qml/blob/649c2a5af80092e4f43497309aafe5785a2b2bdd/src/qml/README.md?plain=1#L73

GBKS commented 3 months ago

Already merged, but I just tested on Android and MacOS and the UI works fine. Nice work on this, sounds like file picking was quite the heavy lift to get done.

I agree with the UI proposals up there and will prep respective designs.

GBKS commented 3 months ago

I created a follow-up issue for the directory display in storage settings here. Would be great to get your input on the question I have in that issue.