search

bitcoin-core / gui-qml

Bitcoin GUI (experimental QML-based fork)
MIT License
106 stars 40 forks source link

Blockclock UI bugs #393

Open stackingsaunter opened 3 months ago

stackingsaunter commented 3 months ago

Is there an existing issue for this?

Current behaviour

CleanShot 2024-04-01 at 17 48 34@2x

I also had similar bug with placing of bitcoin logo on Android, Samsung S9

Expected behaviour

  1. Clock should be centered
  2. Bitcoin logo should be centered between % and top of the circle
  3. Clock icon in the nav bar should be visable

Steps to reproduce

Run compiled binary, go to blockclock screen

Relevant log output

debug.log

How did you obtain Bitcoin Core

Pre-built binaries

What version of Bitcoin Core are you using?

v25.99.0-dfad9947e903-dirty

Operating system and version

MacOS Sonoma 14.3.1

Machine specifications

No response

pablomartin4btc commented 3 months ago
  1. Clock should be centered

At the time of my last review #389 that was fixed, at least for Ubuntu.

  1. Bitcoin logo should be centered between % and top of the circle

cc @johnny9

  1. Clock icon in the nav bar should be visable

I think that was going to be done on a separate PR as the #389's author explained.

GBKS commented 3 months ago

Here's an overlay of the screenshot above and the design to illustrate the difference (size and position of the logo/icon).

image

Bitcoin logo should be centered between % and top of the circle

Note that this is not accurate. It is not centered. The spacing measurements can be taken from Figma here.