bitcoin-core / gui-qml

Bitcoin GUI (experimental QML-based fork)
MIT License
106 stars 40 forks source link

Bugfix custom datadir doubleClick - Follow-up #392 #399

Open pablomartin4btc opened 2 months ago

pablomartin4btc commented 2 months ago

This is a desktop-only (not mobile/ android) workaround to disable double-click on custom datadir which is on the StorageLocations.qml componennt.

Double-clicking was causing the file dialog to get open but losing focus and moving to the background, bringing upfront the main window which was useless because the file dialog is modal (issue raised originally by @MarnixCroes on PR #392 but still persists in ongoing PR #397).

pablomartin4btc commented 2 months ago

thanks for picking this up. it doesn't fully fix the problem. I can still repro sometimes, like +- 1 out of 10 times. (double-checked I'm not making an error, like accidentally having the second click change the focus.)

Ok, thanks for testing it promptly. I couldn't reproduce the issue on Ubuntu, are you on Mac?

If we can't fully fix it, I'd need to investigate another approach and close this one.

MarnixCroes commented 2 months ago

are you on Mac?

no, Ubuntu 22.04.4 LTS

pablomartin4btc commented 2 months ago

@MarnixCroes perhaps it has to do with the OS double click (speed?) config, could you please try changing timer interval from 50 to 150 or 300? Thanks!

MarnixCroes commented 2 months ago

@MarnixCroes perhaps it has to do with the OS double click (speed?) config, could you please try changing timer interval from 50 to 150 or 300? Thanks!

I could repro with 150. (happened after 25 tries) I could repro with 300, only after +- 100 tries

pablomartin4btc commented 2 months ago

I could repro with 150. (happened after 25 tries) I could repro with 300, only after +- 100 tries

Thanks for testing it again, let's discuss it tomorrow with the rest of the team on the devs call, so far we can have this as a workaround to solve this bug until we find a better approach.

pablomartin4btc commented 2 months ago

Updates:

pablomartin4btc commented 2 months ago

Updates:

pablomartin4btc commented 1 month ago

Rebased to refresh CIs (#402). No code changes.