search

bitcoin-core / gui-qml

Bitcoin GUI (experimental QML-based fork)
MIT License
106 stars 40 forks source link

Introduce Create Single-Sig wallet flow #403

Open johnny9 opened 1 month ago

johnny9 commented 1 month ago

These changes add more pages after the initial onboarding.

To test, run the application with the -resetguisettings option.

Link to github actions build artifacts.

Build Artifacts

johnny9 commented 1 month ago

tACK 4c047e0 on WSL Ubuntu 22.04.

Wallet creation worked. In general agree with Marnix's comments.

And to be clear is this the first iteration, then layering more functionality (i.e. error messages, wallet name collision and more specific passwords hints )?

Yeah this is just following what was ready in the Figma. I think building it helps identify all of the gaps. I think all of these comments are great and I'll do my best to get these in on this first change-set.

hebasto commented 1 month ago

cc @GBKS

stackingsaunter commented 2 weeks ago

Testing the PR, so far worked well and created a wallet. "View file" button didn't work at all though.

I see other discrepancies (missing options/ different wording) against figma, is this intentional?

Yeah this is just following what was ready in the Figma. I think building it helps identify all of the gaps. I think all of these comments are great and I'll do my best to get these in on this first change-set.

@johnny9 mentioned in the issue in design repo, the lastest Figma design is here and was not yet merged to main Figma file.

It does not differ greatly from what's in this PR. Minor changes were introduced from user testing the flow. All differences should be highlighterd in the file and issue