create wallet: don't allow entry of already existing wallet name - Githubissues

bitcoin-core / gui-qml

Bitcoin GUI (experimental QML-based fork)

MIT License

113 stars 41 forks source link

create wallet: don't allow entry of already existing wallet name #413

Open MarnixCroes opened 3 months ago

MarnixCroes commented 3 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

Current behaviour

currently there is no check if the entered wallet name already exists. it should check it and don't allow it/have a related message

as mentioned in https://github.com/bitcoin-core/gui-qml/pull/403#pullrequestreview-2082083987

Expected behaviour

not able to continue when entering an already existing wallet name.
have a warning/error message that wallet name already exists.

Steps to reproduce

enter existing wallet name

Relevant log output

No response

How did you obtain Bitcoin Core

Compiled from source

What version of Bitcoin Core are you using?

a73577b7b79d541472a80471a6adcadebe6d9deb

Operating system and version

linux

Machine specifications

No response

jarolrod commented 2 months ago

The Qt Widgets allows this, but will then fail to create the wallet, we do want to fail early, so agree with this