search

bitcoin-core / gui

Bitcoin Core GUI staging repository
https://github.com/bitcoin/bitcoin
MIT License
605 stars 267 forks source link

Checkboxes for onlynet combinations #413

Open ghost opened 3 years ago

ghost commented 3 years ago

Is your feature request related to a problem? Please describe

Using onlynet and deciding outbound connection types should be easy for GUI users

Describe the solution you'd like

image

Additional context

There are few issues with onlynet and they should be fixed with https://github.com/bitcoin/bitcoin/pull/22834

Possible combinations are:

ipv4
ipv6
onion
i2p

onion-ipv4
onion-ipv6
i2p-ipv4
i2p-ipv6
i2p-onion
ipv6-ipv4

onion-ipv6-ipv4
i2p-ipv6-ipv4
i2p-onion-ipv4
i2p-onion-ipv6

Ignoring i2p-onion-ipv6-ipv4 because it will be same as not using onlynet. So default can be all options checked if there is nothing mentioned in bitcoin.conf.

jonatack commented 3 years ago

In terms of number of combinations, there may be Bitcoin Core support for additional BIP155 networks in the future.

Rspigler commented 3 years ago

Strong Concept ACK. More settings easily exposed to the GUI the better.

onion and i2p should be unclickable unless installed and setup properly (and maybe also point to documentation so the user can know how).

It would be more complicated, but having an Inbound Connections options would be great as well

Saibato commented 3 years ago

concept ACK

though i would reverse the logic to allow changes that might happen in the future, So how about setting no "s