bitcoin-core / gui

Bitcoin Core GUI staging repository
https://github.com/bitcoin/bitcoin
MIT License
588 stars 259 forks source link

Update icon to fit macOS 11+ style #674

Closed ystolzenburg closed 1 month ago

ystolzenburg commented 1 year ago

Current Bitcoin Core icon does not fit into the rest of macOS since 11 Big Sur, it should be updated to an appropriate squircle.

screenshot of macOS dock, highlighting the difference between native looking and bitcoin core icons
jarolrod commented 1 year ago

Sorry, but this issue is out of scope for the project; this is the logo/icon that has been used and will continue to be used. I would say that it is not true that all macos apps adhere to the "squircle".

ystolzenburg commented 1 year ago

It's true that a minority of apps haven't updated their icon, but it is part of the Human Interface Guidelines that iOS and macOS (since 11) share the same icon shape. A simple white background would be enough.

hebasto commented 1 year ago

Current Bitcoin Core icon does not fit into the rest of macOS since 11 Big Sur

It fits its own style across all supported platforms.

cc @GBKS

GBKS commented 1 year ago

Is it possible to define different icons for different platforms? For the web, there are even special tools to create all the different icons needed for all browsers and operating systems. Could we do the same for this application?

hebasto commented 1 year ago

Is it possible to define different icons for different platforms?

The code in our codebase, which is related to a macOS Dock icon, is macOS-specific already.

katesalazar commented 1 year ago

call the mathematicians to prove that a circle is a more legit squircle than that xcode icon over there in OP post

On Fri, Oct 14, 2022 at 5:59 AM Jarol Rodriguez @.***> wrote:

Sorry, but this issue is out of scope for the project; this is the logo/icon that has been used and will continue to be used. I would say that it is not true that all macos apps adhere to the "squircle".

— Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/gui/issues/674#issuecomment-1278448315, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4W5CVF5SRQUZ2WQKIP3WDDLBJANCNFSM6AAAAAARAKYIAY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

ystolzenburg commented 1 year ago

Would look silly with a bitcoin icon, but that's an extra "detail" to add on top of the regular squircle (or rounded rectangle):

Bildschirmfoto 2022-10-14 um 20 24 33
katesalazar commented 1 year ago

I stand corrected

On Fri, Oct 14, 2022 at 8:25 PM Yannick Stolzenburg < @.***> wrote:

Would look silly with a bitcoin icon, but that's an extra "detail" to add on top of the regular squircle (or rounded rectangle): [image: Bildschirmfoto 2022-10-14 um 20 24 33] https://user-images.githubusercontent.com/46424671/195915441-979e7c44-5c74-47a0-b86a-7ac0de457eb8.png

— Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/gui/issues/674#issuecomment-1279327745, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4WZH2WVHPHVQW73M4BDWDGQSZANCNFSM6AAAAAARAKYIAY . You are receiving this because you commented.Message ID: @.***>

Sjors commented 1 year ago

Evernote uses a circle too:

Scherm­afbeelding 2023-01-24 om 13 58 47

And Apple's own trash can isn't a squircle either:

Scherm­afbeelding 2023-01-24 om 14 00 10

I suspect Apple will change their icon fashion faster than we can ever keep up with :-)

angelday commented 1 month ago

I believe this issue should be closed because bitcoin-core is not a first party UI to the Mac anyway (it uses Qt) therefore making the app icon conforming to the Human Interface Guidelines, in a way, is wasted effort.

To add to the discussion, according to Apple: "In macOS, app icons share a common set of visual attributes, including a rounded-rectangle shape, front-facing perspective, level position, and uniform drop shadow."

Screenshot 2024-08-03 at 07 26 44

https://developer.apple.com/design/human-interface-guidelines/app-icons