search

bitcoin-core / packaging

Distribution-specific packaging for Bitcoin Core
41 stars 43 forks source link

Add bitcoin snap from Gal Buki #9

Closed ryanofsky closed 5 years ago

ryanofsky commented 5 years ago

This pull request adds @torusJKL's snapcraft configuration from his blockchain-snaps repository to the bitcoin-core packaging repository. This way builders for the bitcoin snap can pull from a repository which is associated with the bitcoin project and where changes are reviewed, instead of from a personal repository.

I didn't have to make any changes to the configuration to get it to build and run. I tested a local build generated with the snapcraft command as well as a signed build from build.snapcraft.io. I'd like to follow this pull request up with some more changes like adding a README with instructions to build and run. We will also need to configure snapcraft.io to pull from this github repository.

Adding this snap (and reserving new snap names starting with 'bitcoin*') in the snap store should help with https://bugs.launchpad.net/snapstore/+bug/1803914

ryanofsky commented 5 years ago

Update: I'm working on all the changes matt suggested, but running into problems. Current changes are at: https://github.com/ryanofsky/packaging/commits/snap-work.4.

In the meantime, it might make sense to request that the existing bitcoin snap be removed. Or we could merge this PR as is and request a transfer, so it would pull from this repository instead of a personal repository, and we could have control over the screenshots, description, etc.