cmake: Disable eager MSan in ctime_tests

bitcoin-core / secp256k1

Optimized C library for EC operations on curve secp256k1

MIT License

2.02k stars 977 forks source link

Closed hebasto closed 1 month ago

hebasto commented 1 month ago

The second commit improves the configure summary (similar to https://github.com/hebasto/bitcoin/pull/189.

hebasto commented 1 month ago

Addressed comments:

https://github.com/bitcoin-core/secp256k1/pull/1532#discussion_r1615986643:

avoid // comments which are invalid in C89
https://github.com/bitcoin-core/secp256k1/pull/1532#discussion_r1615994037:

Actually, why are you hard coding compiler IDs at all? This just makes things less flexible, and the check should be enough.

hebasto commented 1 month ago

Addressed comments:

https://github.com/bitcoin-core/secp256k1/pull/1532#discussion_r1616380720:

... to add a commit that makes them consistent, but then we'll also need to #error if !defined(__has_feature).
https://github.com/bitcoin-core/secp256k1/pull/1532#discussion_r1616382346:

... to add a commit that also removes the $GCC check in configure.ac, just to keep the system consistent