search

bitcoin-core / secp256k1

Optimized C library for EC operations on curve secp256k1
MIT License
2.02k stars 977 forks source link

build, ci: Adjust the default size of the precomputed table for signing #1564

Closed hebasto closed 1 week ago

hebasto commented 1 week ago

This PR implements the outcomes from today's IRC meeting:

  1. The default size of the precomputed table for signing is now aligned with Bitcoin Core's default.

  2. The default value in CI has been updated to reflect the new default.

real-or-random commented 1 week ago

@sipa @jonasnick

I wonder how much this is a breaking change. 86 KB is larger than the old default (64KB), so this could be a problem for some users. But since we use static precomputation, this will be at most a build-time issue, so I don't think it deserves a 0.6.0 instead of 0.5.1 (assuming it makes it to the next release).

hebasto commented 1 week ago

... I don't think it deserves a 0.6.0 instead of 0.5.1 (assuming it makes it to the next release).

I agree because there are no API changes.

sipa commented 1 week ago

utACK e2af491263e2f7e086dc7f1925d86660ff265dc6

I agree this is not a breaking change, though it does deserve a release note.