build: 45839th attempt to fix symbol visibility on Windows

bitcoin-core / secp256k1

Optimized C library for EC operations on curve secp256k1

MIT License

2.06k stars 1k forks source link

build: 45839th attempt to fix symbol visibility on Windows #1595

Open real-or-random opened 1 month ago

real-or-random commented 1 month ago

Fixes #1421. See code comments for rationale.

Related meta-bug: #1181. This reminds me that we should move forward with #1359.

fanquake commented 4 weeks ago

I can at least confirm that this "fixes" the output I was seeing in #1421. The most recent comment on the upstream GCC issue is not 100% clear to me.

real-or-random commented 3 weeks ago

The most recent comment on the upstream GCC issue is not 100% clear to me.

Can you elaborate on which part is unclear?

In any case, I could rephrase this such that it says it's a GCC bug. When I wrote it, I wasn't sure yet, but the upstream response seems to confirm that this is a bug.

fanquake commented 3 weeks ago

I've re-read, and yes, it seems like the conclusion is that it is a GCC issue. I guess what is actually unclear is if/when anyone might fix it upstream.

real-or-random commented 2 weeks ago

Okay. I've nevertheless rephrased the comment to make it (hopefully) clearer.