bitcoin-data / mining-pools

Known Bitcoin mining pool coinbase tags and coinbase output addresses. Generated files: https://github.com/bitcoin-data/mining-pools/tree/generated
MIT License
19 stars 12 forks source link

Coinbase output address and coinbase tag for block 683919 don't match #36

Open 0xB10C opened 3 years ago

0xB10C commented 3 years ago

The coinbase output address and coinbase tag for block 683919 don't match.

Based on the coinbase output address 1EepjXgvWUoRyNvuLSAxjiqZ1QqKGDANLW the pool is identified as Houbi Pool. https://github.com/0xB10C/known-mining-pools/blob/b601e8de52c09e9e0b50436b63f5e1251d4ab9f5/pools.json#L669-L672

Based on the coinbase tag /one_more_mcd/ the pool is identified as EMCDPool.

https://github.com/0xB10C/known-mining-pools/blob/b601e8de52c09e9e0b50436b63f5e1251d4ab9f5/pools.json#L539-L542

The address 1EepjXgvWUoRyNvuLSAxjiqZ1QqKGDANLW received coinbase transactions cointaining /HuoBi/. The address was added by @wanghao-huobi in https://github.com/btccom/Blockchain-Known-Pools/pull/77

CC @mutatrum @hsjoberg

0xB10C commented 3 years ago

Generally, for quality assurance, the coinbase tags and output addresses (if both have a match) could be tested for equality. Would be a good way to find potential errors.

mutatrum commented 3 years ago

Running this. It will take a while to go through the whole chain as I didn't optimize the code.

[2021-05-17T22:15:57.538Z] 1EepjXgvWUoRyNvuLSAxjiqZ1QqKGDANLW: Huobi Pool, "/one_more_mcd/": EMCDPool, block: 683919
[2021-05-17T22:16:03.206Z] 1EepjXgvWUoRyNvuLSAxjiqZ1QqKGDANLW: Huobi Pool, "/TMSPOOL/": TMSPool, block: 683709
[2021-05-17T22:16:04.857Z] 1EepjXgvWUoRyNvuLSAxjiqZ1QqKGDANLW: Huobi Pool, "/one_more_mcd/": EMCDPool, block: 683649
[2021-05-17T22:16:11.015Z] 1EepjXgvWUoRyNvuLSAxjiqZ1QqKGDANLW: Huobi Pool, "/one_more_mcd/": EMCDPool, block: 683468
[2021-05-17T22:16:12.741Z] 1EepjXgvWUoRyNvuLSAxjiqZ1QqKGDANLW: Huobi Pool, "/TMSPOOL/": TMSPool, block: 683424
[2021-05-17T22:16:13.533Z] 1EepjXgvWUoRyNvuLSAxjiqZ1QqKGDANLW: Huobi Pool, "/one_more_mcd/": EMCDPool, block: 683395
[2021-05-17T22:16:13.899Z] 1EepjXgvWUoRyNvuLSAxjiqZ1QqKGDANLW: Huobi Pool, "/one_more_mcd/": EMCDPool, block: 683384
[2021-05-17T22:16:20.004Z] 1EepjXgvWUoRyNvuLSAxjiqZ1QqKGDANLW: Huobi Pool, "/one_more_mcd/": EMCDPool, block: 683207

....

[2021-05-17T22:18:22.450Z] 12dRugNcdxK39288NjcDV4GX7rMsKCGn6B: AntPool, "/1THash/": 1THash, block: 679528
[2021-05-17T22:18:24.217Z] 12dRugNcdxK39288NjcDV4GX7rMsKCGn6B: AntPool, "/1THash/": 1THash, block: 679477
0xB10C commented 3 years ago

That's awesome, thanks! I guess there is no need to check the whole chain, i previously tested the identification starting at height 300000.

Seems like there are quite a few Huobi ≠ EMCD mismatches... And TSMPool too??

mutatrum commented 3 years ago

Not sure where it's at now, process is still running but didn't produce anything for a while. It seems it's below block 300k (it runs in reverse) so that matches what you state.

The list of address vs. tag mismatches:

address pool tag pool
12dRugNcdxK39288NjcDV4GX7rMsKCGn6B AntPool /1THash/ 1THash
155fzsEBHy9Ri2bMQ8uuuR3tv1YzcDywd4 BitClub ckpool CKPool
1AZ6BkCo4zgTuuLpRStJH8iNsehXTMp456 BitcoinIndia /Bitcoin-India/ Bitcoin India
165GCEAx81wce33FWEnPCRhdjcXCrBJdKn BitcoinRussia /Bitcoin-Ukraine.com.ua/ Bitcoin-Ukraine
1jKSjMLnDNup6NPgCjveeP9tUn4YpT94Y BTCMP ckpool CKPool
1Ca1KNQQo8akbrwTjjXuk8aikvC2pwodU2 BTCPool BTCPool BTCPool (unidentified)
1JLRXD8rjRgQtTS9MvfQALfHgGWau9L9ky BWPool ckpool CKPool
1Afcpc2FpPnREU6i52K3cicmHdvYRAH9Wo CANOE /CANOE/ CanoePool
1BX5YoLwvqzvVwSrdD4dC32vbouHQn2tuF Cointerra Eligius Eligius
16GsNC3q6KgVXkUX7j7aPxSUdHrt1sN2yN Eobot /solo.ckpool.org/ Solo CK
17judvK4AC2M6KhaBbAEGw8CTKc9Pg8wup HotPool ckpool CKPool
18Zcyxqna6h7Z7bRjhKvGpr8HSfieQWXqj Huobi Pool /one_more_mcd/ EMCDPool
1EepjXgvWUoRyNvuLSAxjiqZ1QqKGDANLW Huobi Pool /one_more_mcd/ EMCDPool
18Zcyxqna6h7Z7bRjhKvGpr8HSfieQWXqj Huobi Pool /TMSPOOL/ TMSPool
1EepjXgvWUoRyNvuLSAxjiqZ1QqKGDANLW Huobi Pool /TMSPOOL/ TMSPool
1EowSPumj9D9AMTpE64Jr7vT3PJDNopVcz MiningKings ckpool CKPool
1KGbsDDAgJN2HDNBjmMHp9828qATo5B9c9 MiningKings ckpool CKPool
12znnESiJ3bgCLftwwrg9wzQKN8fJtoBDa shawnp0wers ckpool CKPool
18HEMWFXM9UGPVZHUMdBPD3CMFWYn2NPRX shawnp0wers ckpool CKPool
12Taz8FFXQ3E2AGn3ZW1SZM5bLnYGX4xR6 Tangpool HAOBTC Bixin
18ikmzPqk721ZNvWhDos1UL4H29w352Kj5 Telco 214 ckpool CKPool
125K2xfiBdae42gSKiCGwi85Frpy1vHmGj UKRPool /hash.okkong.com/ OKKONG
1FLH1SoLv4U68yUERhDiWzrJn5TggMqkaZ Waterhole /BTC.COM/ BTC.com

I've attached the log, so you can lookup specific blocks:

pools.log

I'm not familiar on how the addresses are gathered, so I don't know how to proceed from here.

0xB10C commented 3 years ago

Thanks! I'll have a look soon. I know that e.g UKRPool and OKKONG merged.