Closed 0xB10C closed 1 year ago
Recently, Slush has been renamed to Braiins.
Using this new format, we probably want to update both the name
field and the id
field, for consistency. The problem by doing so is that it makes detecting the change less straightforward, since the id
field would be changed.
What do you think of having the id
field has an unique number (from 1 to N), which will never change? This way we could update anything we want without relying on strings.
On our end at mempool, we would continue to generate url slugs
dynamically based on the name like so:
slug = name.replace(/[^a-z0-9]/gi, '').toLowerCase();
What do you think of having the
id
field has an unique number (from 1 to N), which will never change? This way we could update anything we want without relying on strings.
Makes sense! Doing this in https://github.com/0xB10C/known-mining-pools/pull/76. Will rebase this PR here once #76 is merged.
rebased
Recently, Slush has been renamed to Braiins.
This is still to-be-done. Tracking this in https://github.com/0xB10C/known-mining-pools/issues/77.
All
pool/*.json
files as a JSON list. This makes it easy to download the data. To be used by, for example, mempool-space (https://github.com/mempool/mining-pools/issues/25).Also updating the QA checks for the CI check if the file is up-to-date. However, at some point in the future it makes sense to re-generate the file on each merged PR in the CI and push the output to another branch.