bitcoin-dev-project / bitcoiner-intro-to-rust

The Bitcoiner's Introduction to Rust
68 stars 18 forks source link

CompactSize includes 0 #27

Closed sb1752 closed 3 months ago

sb1752 commented 4 months ago

Technically, the compactSize includes 0, but we start at 1 in lesson 10 to avoid 0 inputs.

Should make this more clear as it will create confusion later on in chapter 22. Perhaps can simply check if there are 0 inputs and then panic! early on and fix the compactSize function implementation.