bitcoin-dev-project / sim-ln

Payment activity generator for the lightning network
MIT License
63 stars 27 forks source link

sim-lib: Get rid of nested json for node definition #152

Closed sr-gi closed 11 months ago

sr-gi commented 11 months ago

I must have been way more sleep-deprived than I thought when originally designing this, but we don't really need the nested json with node type tags to parse node information (as long as the node info has, at least one different field name).

Mainly, this goes from:

"nodes": [
    {
        "LND": {
            "id": "...",
            "address": "...",
            "macaroon": "...",
            "cert": "..."
        }
    },
    {
        "CLN": {
            "id": "...",
            "address": "...",
            "ca_cert": "...",
            "client_cert": "...",
            "client_key": "..."
        }
    }
]

To:

"nodes": [
    {
        "id": "...",
        "address": "...",
        "macaroon": "...",
        "cert": "..."
    },
    {
        "id": "...",
        "address": "...",
        "ca_cert": "...",
        "client_cert": "...",
        "client_key": "..."
    }
]
carlaKC commented 11 months ago

Let's get this done with high priority if we're going to change it, told the warnet folks to wait on a stable config file before they proceed.

sr-gi commented 11 months ago

Let's get this done with high priority if we're going to change it, told the warnet folks to wait on a stable config file before they proceed.

On it

sr-gi commented 11 months ago

@carlaKC should be good now