search

bitcoin-dev-project / sim-ln

Payment activity generator for the lightning network
MIT License
63 stars 28 forks source link

Refactor: Use From<PaymentPreimage> when constructing PaymentHash #172

Open sr-gi opened 8 months ago

sr-gi commented 8 months ago

https://github.com/bitcoin-dev-project/sim-ln/pull/165 introduces the use of PaymentHash manually building from PaymentPreimage. Recently, LDK added the ability to build the former from the latter into their API: https://github.com/lightningdevkit/rust-lightning/pull/2916.

Update our LDK version and replace the manual construction from the corresponding call when it gets released

Anyitechs commented 7 months ago

I'll like to work on this issue. Should I go ahead and send a draft PR for it?

cc: @sr-gi @carlaKC

carlaKC commented 7 months ago

Should I go ahead and send a draft PR for it?

lightningdevkit/rust-lightning/pull/2916 hasn't landed in a release yet so we should wait for that.

If you'd like something to pick up, we bumped our lightning version but never finished #131 to update the way that we handle feature vectors.

Anyitechs commented 7 months ago

Should I go ahead and send a draft PR for it?

lightningdevkit/rust-lightning/pull/2916 hasn't landed in a release yet so we should wait for that.

If you'd like something to pick up, we bumped our lightning version but never finished #131 to update the way that we handle feature vectors.

Ok great. I'll jump on that then. Thank you.