Validate zero amount in a defined activity

bitcoin-dev-project / sim-ln

Payment activity generator for the lightning network

MIT License

63 stars 28 forks source link

Validate zero amount in a defined activity #180

Closed joseguru closed 6 months ago

joseguru commented 7 months ago

This PR addresses the issue #176 . This has been done by updating the validate_activity function

updated validate_activity to disallow zero values.
Throws a validation error when amount_msat is 0 on a defined activity

joseguru commented 7 months ago

Hello @carlaKC we were having a chat with @Anyitechs on the where to place test files. The current implementation has tests written on each file , for example defined_activity.rs has tests written on it. Can these tests files be separated to a tests directory then have individual test file for each implementation?

carlaKC commented 7 months ago

Hello @carlaKC we were having a chat with @Anyitechs on the where to place test files. The current implementation has tests written on each file , for example defined_activity.rs has tests written on it. Can these tests files be separated to a tests directory then have individual test file for each implementation?

We're following the rust convention of including tests in the same file in a different module - I don't really see a compelling reason to move them into another file?

carlaKC commented 6 months ago

Closing due to inactivity, please feel free to re-open if you've got time to pick this up again.

joseguru commented 6 months ago

Hi @carlaKC Been working on it on the side . Been trying to work on mocking a Simulation as per your instructions. So its work in progress