bitcoin-dev-project / warnet

Monitor and analyze the emergent behaviors of Bitcoin networks
https://warnet.dev
MIT License
59 stars 27 forks source link

catch fewer errors #317

Open pinheadmz opened 1 month ago

pinheadmz commented 1 month ago

I think we need to be less afraid to raise exceptions. try/except blocks like the one below are counter productive. In recent CI runs for example, wait_for_health() fails, meaning apply_network_conditions() is just skipped, but the test continues to run along.

Somewhat related to https://github.com/bitcoin-dev-project/warnet/issues/198

https://github.com/bitcoin-dev-project/warnet/blob/44102004f9535bcc82a67b71de4138bfd826bb78/src/warnet/server.py#L472-L485