Closed willcl-ark closed 1 month ago
An example of the new CI workflow can be seen here: https://github.com/willcl-ark/warnet/actions/runs/8546726444
An example of the new CI workflow can be seen here: https://github.com/willcl-ark/warnet/actions/runs/8546726444
Looks awesome and i believe it is working as expected
#18 pushing manifest for docker.io/***/***:latest@sha256:c8f4f4abd7dc92de48527396e8479dc4d8039c77626c5ebd6a4c24be27ea50ab
Using tagname: will8clark/warnet-rpc:latest
Which I can see on dockerhub:
sha256:c8f4f4abd7dc92de48527396e8479dc4d8039c77626c5ebd6a4c24be27ea50ab
My only concern is using the tagname instead of, for example
will8clarkwarnet-rpc@sha256:c8f4f4abd7dc92de48527396e8479dc4d8039c77626c5ebd6a4c24be27ea50ab
just in case there is some weird thing with force pushing to a branch multiple times or a cancelled workflow or something like that
I think this can go in if CI passes. I cannot pass env var between jobs despite an hours worth of attempts like this.
OK a new example with (most of) @pinheadmz comments addressed: https://github.com/willcl-ark/warnet/actions/runs/8560281420
Also restructure CI into single workflow. This makes it much easier to depend on other workflows, and also use workflow artifacts between jobs.
Also, add another matrix to the workflow to make it DRY-er
Finally, re-add required MANIFEST.in
cc @pinheadmz