search

bitcoin-dev-project / warnet

Monitor and analyze the emergent behaviors of Bitcoin networks
https://warnet.dev
MIT License
59 stars 27 forks source link

sort import to make ruff happy #350

Closed mplsgrant closed 3 weeks ago

mplsgrant commented 3 weeks ago

Issue

Current CI is failing because ruff is unhappy that some of our imports are unsorted.

Solution

Perform a ruff --fix to sort the imports.

willcl-ark commented 3 weeks ago

Thanks for this. The change is correct, but I feel like it's highlighting that something in our CI is off; for example the PR I merged was passing and this one is failing, which is the inverse of what should be happening...

Just trying to figure out why.

willcl-ark commented 3 weeks ago

I'm wondering now if we need these lines in the ruff checkout step too.

Alternatively we could extract Ruff into its own workflow and have it run on pull_request, as we don't need pull_request_target for it.

willcl-ark commented 3 weeks ago

Going to merge this for now, and fix properly later.