search

bitcoin-dev-project / warnet

Monitor and analyze the emergent behaviors of Bitcoin networks
https://warnet.dev
MIT License
59 stars 27 forks source link

Ruff CI does not appear to be checking PR branch #351

Open willcl-ark opened 3 weeks ago

willcl-ark commented 3 weeks ago

ref: https://github.com/bitcoin-dev-project/warnet/pull/350#issuecomment-2077878932

mplsgrant commented 3 weeks ago

I wonder if we should separate out our CI in to a pull_request_target section and a pull_request section. I see that some of the workflow requires github secrets, and so I think that means it must use pull_request_target. The ruff workflow does not need secrets which means we can package it into an on: pull_request workflow and that would help us avoid this issue.