search

bitcoin-dev-project / warnet

Monitor and analyze the emergent behaviors of Bitcoin networks
https://warnet.dev
MIT License
81 stars 35 forks source link

Refactor historic CVE images #508

Closed josibake closed 4 days ago

josibake commented 2 weeks ago

Lots of duplication in the current historic CVE images, would be nice to refactor this a bit into a common base image, where version specific changes are then applied as much smaller images, e.g.,

FROM warnet-base-image

# specific fixes with comments

Additionally, it would be nice to document the specific changes for each image. This is with the idea we may need to rebuild/edit these images at some point in the future, so just some good housekeeping to ensure maintainability.

Lower priority for now.

willcl-ark commented 1 week ago

This is with the idea we may need to rebuild/edit these images at some point in the future, so just some good housekeeping to ensure maintainability

The images can be re-built now or any time in the future as they are currently in #498 (simly docker build ...), but I will happily review a PR refactoring commonality out of them if you see value in that.

willcl-ark commented 4 days ago

closed by #539