search

bitcoin-dev-project / warnet

Monitor and analyze the emergent behaviors of Bitcoin networks
https://warnet.dev
MIT License
83 stars 35 forks source link

configs, configs, configs #511

Open josibake opened 3 weeks ago

josibake commented 3 weeks ago

Per https://github.com/bitcoin-dev-project/warnet/pull/507#discussion_r1741850547, we are starting to have a few places where configs are defined that rely on shared defaults (rpc ports, rpc usernames and passwords, etc).

Generally speaking, I don't think config values should need a PR to change: they should have a sane default (specified in the values.yaml for each chart, perhaps?) and then a way for the user to supply an override at run time.

We might need to rely on just making sure each values.yaml uses the same default for things like rpc ports. Even better, have a CI check that ensures these don't get out of sync over time.

Another idea would be for anything that requires coordination across multiple helm charts, e.g. rpc port, these must be defined outside the values.yaml file and injected into each chart via some sort of generic config.

willcl-ark commented 3 weeks ago

https://github.com/bitcoin-dev-project/warnet/pull/513 is tangential but helps describe this relationship to users and contributors:

https://github.com/willcl-ark/warnet/blob/value-prop/docs/config.md