search

bitcoin-dot-org / developer.bitcoin.org

Bitcoin.org Developer Documentation
https://developer.bitcoin.org/
Other
174 stars 139 forks source link

Fixed sphinx build warnings #104

Closed tushar-1728 closed 3 years ago

turkycat commented 3 years ago

What is the status of this PR? I see it has been approved. @tushar-1728 - are you going to check this in?

I'm working on some additional improvements to the developer docs and would like to build on this. For now, I've cherry-picked from @tushar-1728 's fork. @ssb402 - are you still maintaining this repo?

shobitb commented 3 years ago

What is the status of this PR? I see it has been approved. @tushar-1728 - are you going to check this in?

I'm working on some additional improvements to the developer docs and would like to build on this. For now, I've cherry-picked from @tushar-1728 's fork. @ssb402 - are you still maintaining this repo?

Hey @turkycat - To the best of my knowledge, I'm not maintaining this repo. Actually, I'm not sure whether I am; I never signed up to be one and I don't know how this repo works. I'm quite new to this and this was my first comment on @tushar-1728 's PR.

turkycat commented 3 years ago

What is the status of this PR? I see it has been approved. @tushar-1728 - are you going to check this in? I'm working on some additional improvements to the developer docs and would like to build on this. For now, I've cherry-picked from @tushar-1728 's fork. @ssb402 - are you still maintaining this repo?

Hey @turkycat - To the best of my knowledge, I'm not maintaining this repo. Actually, I'm not sure whether I am; I never signed up to be one and I don't know how this repo works. I'm quite new to this and this was my first comment on @tushar-1728 's PR.

my mistake, I assumed you were a maintainer since you approved the PR. thanks!

tushar-1728 commented 3 years ago

hi @turkycat, i do not have the write access to merge this repo to the master branch. If you meant something else, do tell.

tushar-1728 commented 3 years ago

Hey @Cobra-Bitcoin, can you please review this pull request, if any change needs to be done, inform me I will make those changes. Once done you can merge this pull request.

Cobra-Bitcoin commented 3 years ago

Thank you. I have merged. Those build warnings were annoying!

tushar-1728 commented 3 years ago

Hey @turkycat, the pull request has been merged to the master branch, so I think there shouldn't be any problem.

mspaansen commented 3 years ago

I hope i did it right

Outlook voor Androidhttps://aka.ms/AAb9ysg downloaden

From: Tushar Raj @.> Sent: Saturday, April 10, 2021 4:55:07 PM To: bitcoin-dot-org/developer.bitcoin.org @.> Cc: Subscribed @.***> Subject: Re: [bitcoin-dot-org/developer.bitcoin.org] Fixed sphinx build warnings (#104)

Hey @turkycathttps://github.com/turkycat, the pull request has been merged to the master branch, so I think there shouldn't be any problem.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/bitcoin-dot-org/developer.bitcoin.org/pull/104#issuecomment-817148952, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJ2R4VY5G3LVDFZ7PBLB7WDTIBREXANCNFSM4TNVEWUA.