bitcoin-pow / BitcoinPoW

BitcoinPoW
https://bitcoin-pow.org
MIT License
16 stars 6 forks source link

Restore creation of legacy wallet #38

Closed bitcoin-pow closed 6 months ago

bitcoin-pow commented 6 months ago

Please describe the feature you'd like to see added.

https://github.com/mraksoll4 code updates

this restore creation of legacy wallet.dat , what support POS logic via

    LegacyScriptPubKeyMan* spk_man = GetLegacyScriptPubKeyMan();
    if (!spk_man)
    {
        LogPrint(BCLog::COINSTAKE, "CreateCoinStake : failed to get signing provider\n");
        return false;
    }

pos logic not support sing from descriptor wallet if you create fresh wallet.dat.

even at address start at 1 you get CreateCoinStake : failed to get signing provider

so temp solution allow users to create legacy wallet , or 26 wallet now simple not usable for new users, they cannot mine at it.

explain if you create new wallet at version 26 - you default create descriptor wallet , and there no matter what address type you use , it working over descriptor sing logic so at debug=1 you get CreateCoinStake : failed to get signing provider

now solution create wallet at 21 and put wallet.dat to folder 26 , and not touch migration.

this simple allow users to use it as is before solution for desctriptor will be found ( at process)

it simple allow at QT interface at creation wallet choise wallet type , notting else.

create at ver 26 - new wallet , there will be no choice create non descrptor wallet.

then create legacy addreses and try send to them any amount.

when you start mining you will always get CreateCoinStake : failed to get signing provider due using GetLegacyScriptPubKeyMan()

this fix restore menu to create non descriptor what don't have any problem at 26 or 27 ( tested also ) or 26 wallet simple not usable for mining if you create wallet at it.

Is your feature related to a problem, if so please describe it.

No response

Describe the solution you'd like

No response

Describe any alternatives you've considered

No response

Please leave any additional context

No response