Closed fanquake closed 1 year ago
I guess the Prebuild
task needs to run after the merge_base
step, or similar.
Not sure how to easily run a step before the build.
Ideally this is something fixed by upstream, see:
For now the only workarounds I see are:
I think "rebase if this is seen" is an ok solution here. Should we close for now?
Note for reviewers if they encounter a rebase: https://github.com/bitcoin/bitcoin/blob/master/doc/productivity.md#diff-the-diffs-with-git-range-diff
I think "rebase if this is seen" is an ok solution here.
~It doesn't work: before rebasing --> after rebasing.~
UPD. nm
That seems unrelated, see https://github.com/bitcoin/bitcoin/pull/25797/files#r1206672381
That seems unrelated, see #25797 (files)
Indeed. Sorry for noise.
Closing this again.
Jup, this was fixed upstream
Failure here: https://cirrus-ci.com/task/4581145136857088 in #27479. Does this just need a rebase? cc @MarcoFalke