Closed theuni closed 1 week ago
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For detailed information about the code coverage, see the test coverage report.
See the guideline for information on the review process. | Type | Reviewers |
---|---|---|
ACK | instagibbs, maflcko |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
I should've mentioned in the description that all of these already have proper annotations in their corresponding declarations which is why they're safe to remove. But reviewers should obviously double-check that.
ACK 5729dbbb7424d02c5e5bc4f2eb340fdc1c0100b4
manually checked that all these annotations still live in the declarations
ACK 5729dbbb7424d02c5e5bc4f2eb340fdc1c0100b4 🦋
These annotations belong in the declarations rather than the definitions. While harmless now, future versions of clang may warn about these.
Discovered these using the upstream WIP: https://github.com/llvm/llvm-project/pull/67520