Breaking change in itsdangerous lib causes problems with the PIP library

bitcoinaverage / api-integration-examples

Bitcoin and Ethereum price API integration examples in csharp, java, nodejs, golang, python, php and ruby

https://apiv2.bitcoinaverage.com/

63 stars 35 forks source link

Breaking change in itsdangerous lib causes problems with the PIP library #17

Open goraniliev opened 5 years ago

goraniliev commented 5 years ago

There is a breaking change in itsdangnerous 1.1 (released on Oct 26, 2018). Namely, there is no SigningAlgorithm anymore, which is used by bitcoinaverage PIP lib (_base_client.py).

Users can install an older version (itsdangerous==0.24 for instance) and that would fix the problem. However, this needs to be fixed in the library as well.

Cheers!

KolevDarko commented 5 years ago

Hey @goraniliev Thanks for the update.

keithritt commented 5 years ago

This is a simple fix: I would fork and submit a push request myself, but I don't see a repo for the actual library. File: bitcoinaverage\clients_base_client.py

Change import statements to:

from itsdangerous import Signer, want_bytes from itsdangerous.signer import SigningAlgorithm