search

bitcoincashorg / spec

Technical specifications
112 stars 64 forks source link

Add optional NODE_BITCOIN_CASH service bit description #16

Closed ftrader closed 7 years ago

ftrader commented 7 years ago

Clients do not have to implement this, but it helps other network software distinguish UAHF nodes from non-UAHF nodes, and is thus helpful.

deadalnix commented 7 years ago

I would liek to have some native speaker validate that the sentence is indeed correct. Except that LGTM.

ptschip commented 7 years ago

I would just say "The client should implement service bit 5 (value 0x20) to indicate support for BitcoinCash" it doesn't matter what string you decide to show in your UI or what variable name you choose for the enumerator, but you could suggest using NODE_BITCOIN_CASH for the enumerator and "CASH" for the ui string, but they're not requirements.

ftrader commented 7 years ago

I think it matters a little bit what you show in your UI because that's what people will use to talk about it. That's why I stuck with using NODE_BITCOIN_CASH / CASH when I could've used NODE_UAHF / UAHF. In the end, yes, these are implementation choices except for the numeric value. But I think it helps to have a common terminology (and I think CASH more memorable than UAHF).

I'll move the NODE_BITCOIN_CASH / CASH to a note.

zander commented 7 years ago

I approve of this idea and the bit looks good to me too.

I suggest posting this idea upon merge to the bitcoin-ml list to notify the general public of you 'claiming' this bit.

ftrader commented 7 years ago

Updated based on interpolating @ptschip 's remark .

ftrader commented 7 years ago

Added version number bump.

Are we ok with the updates as-is?