schancel
commented
6 years ago It's not a bad idea, but it's unfortunately too late to change easily.
It's worth noting though that this instead makes the decoded byte array difficult to deal with.
Closed lvella closed 6 years ago
schancel
commented
6 years ago It's not a bad idea, but it's unfortunately too late to change easily.
It's worth noting though that this instead makes the decoded byte array difficult to deal with.
Instead of 8 bits for version, split in 1 (reserved) + 4 (type) + 3 (size) bits, maybe we should use instead a total of 10 bits, to make it boundary aligned with the character division of 5 bits each.
Te meaning could be 1 (reserved) + 4 (type) + 5 (size, optional?, could be ommited if type is not P2SH).