bitcoindevkit / bdk-cli

A CLI wallet library and REPL tool to demo and test the BDK library
Other
108 stars 64 forks source link

Remove some of the reserves and regtest features #100

Closed rajarshimaitra closed 2 years ago

rajarshimaitra commented 2 years ago

Description

Currently the way ExternalReserves functionality is written, it can only be used with electrum feature. The tests should fail if the implementation behavior is enforced.. Disabling the tests in CI.

Also removing the regtest-esplora features from the tests, because they won't work when #92 lands.

Notes to the reviewers

Checklists

All Submissions:

rajarshimaitra commented 2 years ago

@notmandatory we need to get this one merged before we can make the CI pass for #99 and #102 ..