bitcoindevkit / bdk-cli

A CLI wallet library and REPL tool to demo and test the BDK library
Other
108 stars 64 forks source link

Add add_data enables op_return for bdk-cli #105

Closed waterst0ne closed 1 year ago

waterst0ne commented 2 years ago

Description

This enables users to send an arbitrary string message through a txn-output. The maximum size of this string-literal can be length of 80-bytes.

Notes to the reviewers

Checklists

All Submissions:

New Features:

Bugfixes:

notmandatory commented 2 years ago

Overall looks good! I made a few comments above. Also you need to run cargo clippy and fix what ever clippy tells you to.

waterst0ne commented 2 years ago

Overall looks good! I made a few comments above. Also you need to run cargo clippy and fix what ever clippy tells you to.

All changes have been updated, everything looks good to go! Thank you for testing @notmandatory . 🚀

waterst0ne commented 1 year ago

Rebased on the latest master ready for final review please.