As BDK bumped its stable to 1.65, it is safe for us to move it up also.
Notes to the reviewers
1.65 cause clippy warning that Eq isn't derived while PartialEq is derived for the commands. We can't derive Eq for commands, as there is a fee_rate which is f32 which isn't Eq, and this effect cascades to all structures. We also need PartialEq for the tests.
A few options were:
allow the clippy warning conditionally for 1.65, 1.57 doesn't have that lint. The way to do that is by creating custom features for different versions and making a build script that activates specific features for specific versions. Feature gate the clippy lint. or use https://github.com/dtolnay/rustversion which is an extra dep.
Remove PartialEq and create a method on CliOpts to translate it into Vec<String>, and then perform the tests.
Make fee_rateu32 and derive Eq for all.
I went for the last option as it seemed less complex, and not too bad(?). For bdk_cli as majorly a testing tool, it might not need floating point granularity and users can still test out with u32 fee_rates. Internally it converts it back to f32.
I removed the derive for Eq on a CliOpts and a few others so that we can leave the FeeRate amount as a f32. Clippy for 1.65 is still happy with all the changes.
Description
As BDK bumped its stable to 1.65, it is safe for us to move it up also.
Notes to the reviewers
1.65
cause clippy warning thatEq
isn't derived whilePartialEq
is derived for the commands. We can't deriveEq
for commands, as there is afee_rate
which isf32
which isn'tEq
, and this effect cascades to all structures. We also needPartialEq
for the tests.A few options were:
allow the clippy warning conditionally for
1.65
,1.57
doesn't have that lint. The way to do that is by creating custom features for different versions and making a build script that activates specific features for specific versions. Feature gate the clippy lint. or use https://github.com/dtolnay/rustversion which is an extra dep.Remove
PartialEq
and create a method onCliOpts
to translate it intoVec<String>
, and then perform the tests.Make
fee_rate
u32
and deriveEq
for all.I went for the last option as it seemed less complex, and not too bad(?). For bdk_cli as majorly a testing tool, it might not need floating point granularity and users can still test out with
u32
fee_rates. Internally it converts it back tof32
.Suggestions welcome.
Changelog notice
stable
to 1.65.Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing