bitcoindevkit / bdk-cli

A CLI wallet library and REPL tool to demo and test the BDK library
Other
108 stars 64 forks source link

bump stable rustc version to 1.65 #140

Closed rajarshimaitra closed 1 year ago

rajarshimaitra commented 1 year ago

Description

As BDK bumped its stable to 1.65, it is safe for us to move it up also.

Notes to the reviewers

1.65 cause clippy warning that Eq isn't derived while PartialEq is derived for the commands. We can't derive Eq for commands, as there is a fee_rate which is f32 which isn't Eq, and this effect cascades to all structures. We also need PartialEq for the tests.

A few options were:

I went for the last option as it seemed less complex, and not too bad(?). For bdk_cli as majorly a testing tool, it might not need floating point granularity and users can still test out with u32 fee_rates. Internally it converts it back to f32.

Suggestions welcome.

Changelog notice

Checklists

All Submissions:

notmandatory commented 1 year ago

I removed the derive for Eq on a CliOpts and a few others so that we can leave the FeeRate amount as a f32. Clippy for 1.65 is still happy with all the changes.