Added validate_domain Electrum option

anmode commented 1 year ago

Description

fixes #134

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

[x] I've signed all my commits
[x] I followed the contribution guidelines
[x] I ran cargo fmt and cargo clippy before committing

New Features:

[ ] I've added tests for the new feature
[ ] I've added docs for the new feature
[ ] I've updated CHANGELOG.md

Bugfixes:

[ ] This pull request breaks the existing API
[ ] I've added tests to reproduce the issue which are now passing
[ ] I'm linking the issue being fixed by this PR cc @rajarshimaitra @danielabrozzoni

anmode commented 1 year ago

Sorry! Now after testing I pushed. I Hope all check to pass.

notmandatory commented 1 year ago

Hi, thanks for adding a validate_domain option, can you make it a flag instead of something that takes a true or false value? See here: https://docs.rs/clap/latest/clap/_derive/_tutorial/index.html#flags

anmode commented 1 year ago

Ohh okay!! I tried!.

anmode commented 1 year ago

Sorry, Actually, i am new so didn't know about what testing commands are. As I did cargo fmt , cargo clippy, and cargo test. All goes well. I see in github action workflow cargo test --no-default-features --features repl,electrum. Ok I'll make changes and push soon!

bitcoindevkit / bdk-cli