add validate domain option to electrum - Githubissues

bitcoindevkit / bdk-cli

A CLI wallet library and REPL tool to demo and test the BDK library

Other

108 stars 64 forks source link

add validate domain option to electrum #155

Open dspicher opened 1 year ago

dspicher commented 1 year ago

Description

Added the validate_domain option to Electrum arguments.

Since https://github.com/bitcoindevkit/bdk-cli/pull/151 seems dormant, I took another stab at this.

Fixes https://github.com/bitcoindevkit/bdk-cli/issues/134.

Changelog notice

Added the validate_domain option to Electrum arguments.

Checklists

All Submissions:

[x] I've signed all my commits
[x] I followed the contribution guidelines
[x] I ran cargo fmt and cargo clippy before committing

New Features:

[x] I've added tests for the new feature
[x] I've added docs for the new feature
[x] I've updated CHANGELOG.md

notmandatory commented 1 year ago

Take a look at the utils.rs file and on line 403 you need to use this new param you're adding.

dspicher commented 1 year ago

Take a look at the utils.rs file and on line 403 you need to use this new param you're adding.

Ah yeah, makes sense. Fixed.