search

bitcoindevkit / bdk-cli

A CLI wallet library and REPL tool to demo and test the BDK library
Other
108 stars 64 forks source link

add payjoin support #156

Open willowenss opened 1 year ago

willowenss commented 1 year ago

Adding payjoin support to bdk-cli

DanGould commented 1 year ago

Note from @notmandatory : "FYI CI is failing on Will’s PR because some dependencies need to be pinned to older versions to work with rust 1.57.. it’s not related to his changes so I’ll need to fix in a different PR"

notmandatory commented 12 months ago

I screwed up while trying to push a CI fix to this PR. @willowenss please force push https://github.com/bitcoindevkit/bdk-cli/commit/5cc9dd44047570c8e148fc097d3c3ac812394879 from your local branch back to this PR branch. Then we can re-open it.

notmandatory commented 12 months ago

Looks like it's passing CI testing! Next steps are:

  1. get commit signing working for your github account
  2. then squash and/or reword your commits to be more descriptive
  3. do final manual testing to confirm it all still works
  4. add any missing tests to make sure it will keep working

https://docs.github.com/en/authentication/managing-commit-signature-verification https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

notmandatory commented 11 months ago

Some new MSRV issues have cropped up, you'll need to amend your last commit to use these cargo update lines:

cargo update -p log --precise 0.4.18
cargo update -p hashlink --precise 0.8.0
cargo update -p tempfile --precise 3.6.0
cargo update -p base64ct --precise 1.5.3
cargo update -p flate2 --precise 1.0.26
cargo update -p h2:0.3.21 --precise 0.3.20
cargo update -p reqwest:0.11.22 --precise 0.11.18
cargo update -p tokio:1.33.0 --precise 1.29.1
cargo update -p tokio-util:0.7.9 --precise 0.7.8
cargo update -p rustls --precise 0.20.8
cargo update -p byteorder --precise "1.4.3"
cargo update -p webpki --precise 0.22.2
cargo update -p cc --precise 1.0.81
cargo update -p os_str_bytes --precise 6.5.1
cargo update -p jobserver --precise 0.1.26
DanGould commented 8 months ago

Looks like this is failing because it depends on bdk 0.27.1 which depends on an ahash version which was yanked due to a side channel attack vulnerability

I'd really like to close this out, but it looks blocked until #166 is merged or otherwise a 0.27.x patch is released with the new ahash 0.7.7. Tricky situation.