search

bitcoindevkit / bdk-cli

A CLI wallet library and REPL tool to demo and test the BDK library
Other
108 stars 64 forks source link

README.md:better markdown syntax for lists #165

Open RandyMcMillan opened 9 months ago

RandyMcMillan commented 9 months ago

This doesnt effect how README.md is rendered on GitHub.com. It enables correct list rendering in other markdown clients.

RandyMcMillan commented 9 months ago

Before:

pr-165-before

After:

pr-165-after

RandyMcMillan commented 9 months ago

6d84b96: update per suggestions

view rendered README.md: https://github.com/bitcoindevkit/bdk-cli/blob/6d84b9601a060e7765aaf819ad30a5201de14195/README.md

6d84b96

feel free to cherry-pick 6d84b96 and close if 854f072 isn't desirable.

thunderbiscuit commented 8 months ago

@RandyMcMillan if you can give me commit access to your PR I'll be able to push some small fixes and get this merged. I'm trying to clean up some of the PRs and move stuff along, sorry it's slow going.

It's apparently a small checkbox that says "Allow edits by maintainers".

RandyMcMillan commented 8 months ago

if there is something else I need to do - please tell me.

Screen Shot 2024-01-14 at 10 34 38 AM

thunderbiscuit commented 8 months ago

Actually this will (I think) work, but in general you don't need to grant complete access to your repo for maintainers to be able to push commits on a PR.

I think this is the article to take a look at: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

thunderbiscuit commented 8 months ago

@notmandatory I don't have permissions to merge this because of the protections on the master branch. The PR currently fails the CI but this is a docs PR and I don't want to get into fixing all the pins on the dependencies here.

notmandatory commented 8 months ago

I think we need to do a couple things before we can merge this PR:

  1. publish release bdk 0.29.1 which has MSRV fixes or just bump MSRV to 1.63 and fix CI in a 0.30.0 version
  2. update bdk-cli to use bdk 0.29.1 and fix any other msrv issues