[bug] Fix RPC tests - Githubissues

bitcoindevkit / bdk-cli

A CLI wallet library and REPL tool to demo and test the BDK library

Other

108 stars 64 forks source link

[bug] Fix RPC tests #56

Closed rajarshimaitra closed 2 years ago

rajarshimaitra commented 2 years ago

Description

There was an inconsistency in rpc tests. The RpcOpts was missing from the wallet struct. This wasn't caught before because we didn't have rpc tests in CI. Fixed that too.

Also removed redundant wallet options from feature gated tests.

Checklists

All Submissions:

[x] I've signed all my commits
[x] I followed the contribution guidelines
[x] I ran cargo fmt and cargo clippy before committing

notmandatory commented 2 years ago

Looks like this one needs a rebase also before it can be merged.

rajarshimaitra commented 2 years ago

Rebased.

notmandatory commented 2 years ago

re-ACK e3f3c3a