bitcoindevkit / bdk-cli

A CLI wallet library and REPL tool to demo and test the BDK library
Other
111 stars 65 forks source link

Update MSRV to current stable, 1.56.1 #59

Closed notmandatory closed 2 years ago

notmandatory commented 2 years ago

Description

Update MSRV to the current stable, 1.56.1 and update the cargo.lock file. Also removed the rust-toolchain file.

Notes to the reviewers

I removed the rust-toolchain file because I don't think we need to lock users into a particular version (or force them to override it), and this file seem to primarily be used for projects using a specific nightly release, see: https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file.

I also had to pin the fd-lock dependency because of a recent update to that crate to use the rustdoc::missing_doc_code_examples feature which is only supported by nightly :disappointed: .

Checklists

All Submissions:

notmandatory commented 2 years ago

Before this is merged we need to change the github expected checks from 1.53.0 to 1.56.1.

notmandatory commented 2 years ago

undoing the pinned fd-lock with #64