Improve error handlings.

bitcoindevkit / bdk-cli

A CLI wallet library and REPL tool to demo and test the BDK library

Other

108 stars 64 forks source link

Improve error handlings. #61

Closed rajarshimaitra closed 2 years ago

rajarshimaitra commented 2 years ago

Description

bdk-cli had lots of ugly unwraps through out the code. All the unwraps inside the library (except tests) were removed and errors were propagated with bdk::Error type.

Checklists

All Submissions:

[x] I've signed all my commits
[x] I followed the contribution guidelines
[x] I ran cargo fmt and cargo clippy before committing

notmandatory commented 2 years ago

LGTM but I think it needs a rebase and fixes to pass CI.

rajarshimaitra commented 2 years ago

Rebased and conflicts resolved..