bitcoindevkit / bdk-cli

A CLI wallet library and REPL tool to demo and test the BDK library
Other
111 stars 65 forks source link

Create Integration tests for bdk-cli #62

Closed rajarshimaitra closed 2 years ago

rajarshimaitra commented 2 years ago

After Proof of Reserves capability is merged in https://github.com/bitcoindevkit/bdk/commit/b2ac4a0dfd33e1286059d0bd090fd9137e2545ba, its time we require some integration tests in the library. Not only for Proof of Reserves functionality, but in general wallet functions too.

This then can be added into CI tests to give us better reliability on the underlying bdk functions.

electrsd can be used similarly to the bdk test framework to simulate a electrum and bitcoin core backend. https://github.com/bitcoindevkit/bdk/blob/64e88f0e006c68315142d53dc35b633327dde4b5/src/testutils/blockchain_tests.rs#L19-L22

rajarshimaitra commented 2 years ago

This has turned out to be more elaborate than I thought.. Definitely not good first issue.. I will include this in an upcoming regtest-node part2 PR..

notmandatory commented 2 years ago

I'm going to merge #89 and #71 for 0.5.0 and then I think we should release it. Can we move this issue to next milestone 0.6.0?

rajarshimaitra commented 2 years ago

Yes I also feel we should release the current bunch before that change, and push this to next release.. Because that PR will have some upstream pendings..

I will open the PR shortly though with those temporary fixes, so we can discuss over the node communication approach and improving the test framework..