bitcoindevkit / bdk-cli

A CLI wallet library and REPL tool to demo and test the BDK library
Other
111 stars 65 forks source link

Add key-value-db and sqlite-db features, separate wallet directories #71

Closed notmandatory closed 2 years ago

notmandatory commented 2 years ago

Description

Notes to the reviewers

This change will help test BDK with different databases, in particular for manually testing DB migrations such as in https://github.com/bitcoindevkit/bdk/pull/502.

Checklists

All Submissions:

New Features:

notmandatory commented 2 years ago

@rajarshimaitra can you take a look at this one?

EDIT: Never mind for now, I'm moving this back to draft so I can make the DB features additive per #75.

notmandatory commented 2 years ago

@rajarshimaitra I changed my mind again on the additive features thing. I still think it'd be good to try but will be a biggish change (if it's even possible) for bdk-cli and probably not worth the effort right now.

This PR is now rebased and should be ready to go.